Add Azure Workload Identity proposal #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Mossaka
added a commit
to Mossaka/spin-operator-msk
that referenced
this pull request
Feb 21, 2025
This adds a new 'workloadIdentity' field to the SpinApp CRD and the controller will detect this field to determine whether or not to apply provider specific labels to enable cloud workload identity. See SKIP spinframework/skips#16 for more details Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Mossaka
added a commit
to Mossaka/spin-operator-msk
that referenced
this pull request
Mar 6, 2025
This adds a new 'workloadIdentity' field to the SpinApp CRD and the controller will detect this field to determine whether or not to apply provider specific labels to enable cloud workload identity. See SKIP spinframework/skips#16 for more details Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
…rent implementation Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
endocrimes
reviewed
May 5, 2025
| workloadIdentity: | ||
| serviceAccountName: "workload-identity-sa" | ||
| providerMetadata: | ||
| azure: true |
There was a problem hiding this comment.
I think this seems reasonable - do we have a sense of what alternative cloud workload identity would look like here? (I haven't spent a huge amount of time on cloud k8s since these became common, so don't have good intuition about what EKS/GKE would look like)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This SKIP adds support for Azure Workload Identity to spin operator.
CC @devigned
Proot of concept:
spinframework/spin-operator#372